Change in vdsm[master]: client: do not protect requests on client side

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Mon May 2 09:23:32 UTC 2016


Piotr Kliczewski has posted comments on this change.

Change subject: client: do not protect requests on client side
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.ovirt.org/#/c/56288/2/lib/yajsonrpc/__init__.py
File lib/yajsonrpc/__init__.py:

Line 92
Line 93
Line 94
Line 95
Line 96
> Why do we use Request for both client and server? it does not make sense.
I do not see real value in having 2 objects holding the same values but being responsible for marshalling from/to byte array to params, method and id.

Is there any example of a framework which splits network message representation like that?


Line 93:                               "%s request." % method)
Line 94: 
Line 95: 
Line 96: class JsonRpcRequest(object):
Line 97:     def __init__(self, method, params=(), reqId=None, protect_passwd=True):
> wow you must stop cuting words. only 2 latters you saved here...  passwd is
Done
Line 98:         self.method = method
Line 99:         if protect_passwd:
Line 100:             self.params = protect_passwords(params)
Line 101:         else:


-- 
To view, visit https://gerrit.ovirt.org/56288
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I197591fbf0fb42647267b6901998324dd02a8080
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list