Change in vdsm[master]: blockSD: Avoid stale lvs

nsoffer at redhat.com nsoffer at redhat.com
Sun May 1 20:50:16 UTC 2016


Nir Soffer has posted comments on this change.

Change subject: blockSD: Avoid stale lvs
......................................................................


Patch Set 2:

(4 comments)

https://gerrit.ovirt.org/#/c/56876/2//COMMIT_MSG
Commit Message:

Line 5: CommitDate: 2016-05-01 13:26:32 +0300
Line 6: 
Line 7: blockSD: Avoid stale lvs
Line 8: 
Line 9: When connecting to iSCSI storage, all lvs are automatically activate -
> activated
Done
Line 10: this seems to be new behavior introduced in during EL7 development that
Line 11: we missed. This creates huge amount of stale devices that are not used
Line 12: by anyone, but slow down significantly lvm commands.
Line 13: 


Line 8: 
Line 9: When connecting to iSCSI storage, all lvs are automatically activate -
Line 10: this seems to be new behavior introduced in during EL7 development that
Line 11: we missed. This creates huge amount of stale devices that are not used
Line 12: by anyone, but slow down significantly lvm commands.
> slow down lvm commands significantly
Done
Line 13: 
Line 14: Even worse, active lv may not reflect the real mapping on storage when
Line 15: we start to use it, leading to unneeded pausing of vms, or even to data
Line 16: corruption.


Line 8: 
Line 9: When connecting to iSCSI storage, all lvs are automatically activate -
Line 10: this seems to be new behavior introduced in during EL7 development that
Line 11: we missed. This creates huge amount of stale devices that are not used
Line 12: by anyone, but slow down significantly lvm commands.
> anything
Done
Line 13: 
Line 14: Even worse, active lv may not reflect the real mapping on storage when
Line 15: we start to use it, leading to unneeded pausing of vms, or even to data
Line 16: corruption.


Line 22: 
Line 23: - setup         called when storage domain monitor produce the storage
Line 24:                 domain object, before starting to monitor the domain.
Line 25: 
Line 26: - teardown      called when storage domain monitor has finished.
> monitoring
Done
Line 27: 
Line 28: The BlockStorageDomain implementation deactivate unused lvs in both
Line 29: setup and teardown to avoid stale devices.
Line 30: 


-- 
To view, visit https://gerrit.ovirt.org/56876
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7227bb43c2e1ee67a6239956aae48173a27f566e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list