Change in vdsm[master]: client: do not protect requests on client side

nsoffer at redhat.com nsoffer at redhat.com
Sun May 1 13:54:13 UTC 2016


Nir Soffer has posted comments on this change.

Change subject: client: do not protect requests on client side
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/56288/2/lib/yajsonrpc/__init__.py
File lib/yajsonrpc/__init__.py:

Line 92
Line 93
Line 94
Line 95
Line 96
Why do we use Request for both client and server? it does not make sense.

We should have a separate class for client request, and server request, each with the behavior that makes sense.

client:
- create from arguments
- encode for the wire

server:
- create from wire format
- decode from wire format
- protect passwords

Thoughts?


-- 
To view, visit https://gerrit.ovirt.org/56288
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I197591fbf0fb42647267b6901998324dd02a8080
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list