Change in vdsm[master]: hooks: Relocate hooking (api) module under lib

edwardh at redhat.com edwardh at redhat.com
Thu Mar 31 18:21:36 UTC 2016


Edward Haas has posted comments on this change.

Change subject: hooks: Relocate hooking (api) module under lib
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/55544/2/Makefile.am
File Makefile.am:

Line 82: 	vdsm-tool/vdsm-tool \
Line 83: 	$(NULL)
Line 84: 
Line 85: PYFLAKES_BLACKLIST = \
Line 86: 	./vdsm/hooking.py \
> can't be that it matched lib/vdsm/hooking.py. it relative to the makefile l
Here is what I get:

$ find . -name vdsm/hooking.py
find: warning: Unix filenames usually don't contain slashes (though pathnames do).  That means that '-name ‘vdsm/hooking.py’' will probably evaluate to false all the time on this system.  You might find the '-wholename' test more useful, or perhaps '-samefile'.  Alternatively, if you are using GNU grep, you could use 'find ... -print0 | grep -FzZ ‘vdsm/hooking.py’'.
$ find . -name hooking.py
./vdsm/hooking.py
./lib/vdsm/hooking.py
$ find . -path vdsm/hooking.py
$ find . -path /vdsm/hooking.py
$ find . -path ./vdsm/hooking.py
./vdsm/hooking.py
Line 87: 	$(NULL)
Line 88: 
Line 89: 
Line 90: .PHONY: gitignore


-- 
To view, visit https://gerrit.ovirt.org/55544
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5f2e0ed06d5f17885b5892bb8659c52f4542a9d9
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list