Change in vdsm[master]: migration: Add retry on full capacity

mbetak at redhat.com mbetak at redhat.com
Thu Mar 31 15:53:25 UTC 2016


Martin Betak has posted comments on this change.

Change subject: migration: Add retry on full capacity
......................................................................


Patch Set 23:

(3 comments)

https://gerrit.ovirt.org/#/c/52799/23/vdsm/virt/migration.py
File vdsm/virt/migration.py:

PS23, Line 338: retry_timeout
> please move as near as possible to its users
here I just wanted to avoid the repeated call to config.getint inside a while loop, that's why it is extracted at this level


PS23, Line 364:                     self.log.debug("Migration destination busy. Initiating "
              :                                    "retry in %d seconds." % retry_timeout)
> let's avoid early formatting:
Done


PS23, Line 673: is_retry_error
> I still don't quite get the need of this trivial method, but I don't really
Thank you for not minding :-) I really think it conveys the *intent* of the method much more clearly than just inline response.is_error


-- 
To view, visit https://gerrit.ovirt.org/52799
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I988fa2e501eb77d121668b22cc533b744a3dc755
Gerrit-PatchSet: 23
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Yaniv Kaul <ykaul at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list