Change in vdsm[master]: Build without supporting python3 by using --disable-python3-...

danken at redhat.com danken at redhat.com
Thu Mar 31 14:01:30 UTC 2016


Dan Kenigsberg has posted comments on this change.

Change subject: Build without supporting python3 by using --disable-python3-support
......................................................................


Patch Set 7:

(1 comment)

https://gerrit.ovirt.org/#/c/55517/7/configure.ac
File configure.ac:

Line 80: )
Line 81: AC_SUBST([PYTHON3_SUPPORT], ["${disable_python3_support}"])
Line 82: AS_IF([test "${disable_python3_support}" = "yes"],
Line 83:       AC_SUBST([PYTHON3_SUPPORT], ['1']),
Line 84:       AC_SUBST([PYTHON3_SUPPORT], ['0']))
> how disable can lead to python3_support = true?
the current logic is wrong. disable_python3_support=yes ends with PYTHON3_SUPPORT='1'. that the opposite of what we want.

you could fix this by flipping the 0 and 1. but the fact that we both were confused by the negatively-named variable suggest that a change is due.

--disable-python3 (ps, I prefer a shorter name over --disable-phthon3-support) can still be used regardless of the name of the variable (see libvirt-selinux below)
Line 85: 
Line 86: 
Line 87: AC_ARG_ENABLE(
Line 88:     [gluster-mgmt],


-- 
To view, visit https://gerrit.ovirt.org/55517
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7437f7dbc2a1e08fcaf8e2a59de6259a94440e0
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list