Change in vdsm[master]: hooks: Relocate hooking (api) module under lib

edwardh at redhat.com edwardh at redhat.com
Thu Mar 31 13:34:08 UTC 2016


Edward Haas has posted comments on this change.

Change subject: hooks: Relocate hooking (api) module under lib
......................................................................


Patch Set 1:

(3 comments)

https://gerrit.ovirt.org/#/c/55544/1/Makefile.am
File Makefile.am:

Line 82: 	vdsm-tool/vdsm-tool \
Line 83: 	$(NULL)
Line 84: 
Line 85: PYFLAKES_BLACKLIST = \
Line 86: 	./vdsm/hooking.py \
> without ./
Without it, it matches both hooking.py files, which is not what we need.
Line 87: 	$(NULL)
Line 88: 
Line 89: 
Line 90: .PHONY: gitignore


https://gerrit.ovirt.org/#/c/55544/1/lib/vdsm/Makefile.am
File lib/vdsm/Makefile.am:

Line 20: include $(top_srcdir)/build-aux/Makefile.subs
Line 21: 
Line 22: SUBDIRS=common netinfo netlink tool infra profiling rpc tc network virt storage
Line 23: 
Line 24: dist_vdsm_PYTHON = hooking.py
> does it work ? not better to leave it in vdsm/Makefile.am?
Done
Line 25: 
Line 26: dist_vdsmpylib_PYTHON = \
Line 27: 	__init__.py \
Line 28: 	cmdutils.py \


https://gerrit.ovirt.org/#/c/55544/1/vdsm/Makefile.am
File vdsm/Makefile.am:

Line 27
Line 28
Line 29
Line 30
Line 31
> but you still have this file.. I don't think it will work if you don't ment
Done


-- 
To view, visit https://gerrit.ovirt.org/55544
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5f2e0ed06d5f17885b5892bb8659c52f4542a9d9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list