Change in vdsm[master]: virt: set correct permissions for hwrng device

mpolednik at redhat.com mpolednik at redhat.com
Thu Mar 31 12:44:53 UTC 2016


Martin Polednik has posted comments on this change.

Change subject: virt: set correct permissions for hwrng device
......................................................................


Patch Set 9:

@Nir: you didn't like the fact that this patch duplicated a bit of logic, you don't like proper refactoring because it's not possible without adding tests (and they cannot be added properly due to hardcoded open paths). This is a 4.0 target bug, any idea about approach?

-- 
To view, visit https://gerrit.ovirt.org/54806
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id958a291e5a15813309928ba3d8c67828273b6c6
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: No


More information about the vdsm-patches mailing list