Change in vdsm[master]: vm: destroy: try harder destroying a Vm

danken at redhat.com danken at redhat.com
Thu Mar 31 10:19:52 UTC 2016


Dan Kenigsberg has submitted this change and it was merged.

Change subject: vm: destroy: try harder destroying a Vm
......................................................................


vm: destroy: try harder destroying a Vm

The current Vm code to destroy a Vm starts
nice, using graceful destroy, and hits harder
if the nice way fails.

However, the failure of the first graceful attempt
is only detected when libvirt returns a specific error code.
Indeed, the return code of libvirt changed between RHEL6 and RHEL7.
This looks fragile and looks like unnecessary detail.

Digging into history, I was not able to find the reason why we look
for a specific error code.

This patch just drops the specific error code check.
Now Vdsm always uses the harsh way if the nice way fails.

Change-Id: Ic6519bf45565ffb879781926f437811a9bf5302b
Bug-Url: https://bugzilla.redhat.com/1309884
Backport-To: 3.6
Signed-off-by: Francesco Romani <fromani at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/53747
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M vdsm/virt/vm.py
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Verified



-- 
To view, visit https://gerrit.ovirt.org/53747
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic6519bf45565ffb879781926f437811a9bf5302b
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the vdsm-patches mailing list