Change in vdsm[master]: testlib: Fix temporaryPath on Python 3.

danken at redhat.com danken at redhat.com
Thu Mar 31 07:55:50 UTC 2016


Dan Kenigsberg has submitted this change and it was merged.

Change subject: testlib: Fix temporaryPath on Python 3.
......................................................................


testlib: Fix temporaryPath on Python 3.

Writing data to files must use bytes objects, not unicode/strings.
Replace os.fdopen() with io.open(path, "wb") creating a buffered file
object for writing binary data.

Change-Id: I939d78a61f5fe1b836f59bee7ef7015cd8e79647
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/55489
Reviewed-by: Francesco Romani <fromani at redhat.com>
Reviewed-by: Yaniv Bronhaim <ybronhei at redhat.com>
Continuous-Integration: Jenkins CI
Reviewed-by: Piotr Kliczewski <piotr.kliczewski at gmail.com>
---
M tests/testlib.py
1 file changed, 3 insertions(+), 4 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, approved
  Nir Soffer: Verified
  Yaniv Bronhaim: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Francesco Romani: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/55489
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I939d78a61f5fe1b836f59bee7ef7015cd8e79647
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the vdsm-patches mailing list