Change in vdsm[master]: image: add a flag for preparing with illegal volumes.

nsoffer at redhat.com nsoffer at redhat.com
Wed Mar 30 17:28:57 UTC 2016


Nir Soffer has posted comments on this change.

Change subject: image: add a flag for preparing with illegal volumes.
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

Waiting for Adam review.

https://gerrit.ovirt.org/#/c/55199/2/lib/api/vdsmapi-schema.json
File lib/api/vdsmapi-schema.json:

Line 5311: # @allowIllegal:     #optional False by default. If set to True, prepare will
Line 5312: #                    succeed even if any of the image volumes are illegal,
Line 5313: #                    for making the volume writable by untrusted source.
Line 5314: #                    *Warning- Never use this when exposing this volume's
Line 5315: #                              image to a vm!
*Warning? 

Please remove uneeded indentation before "image to a vm!"
Line 5316: #
Line 5317: # Returns:
Line 5318: # Information about prepared image
Line 5319: # (new in version 4.18)


-- 
To view, visit https://gerrit.ovirt.org/55199
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie18ab167635e6e099c3a12e03ea6620578c3103f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list