Change in vdsm[master]: v2v: fix handling virt-v2v fail on stream close

nsoffer at redhat.com nsoffer at redhat.com
Wed Mar 30 12:45:03 UTC 2016


Nir Soffer has posted comments on this change.

Change subject: v2v: fix handling virt-v2v fail on stream close
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.ovirt.org/#/c/55477/1/lib/vdsm/v2v.py
File lib/vdsm/v2v.py:

Line 714:         chunk = ''
Line 715:         while True:
Line 716:             c = stream.read(1)
Line 717:             if not c:
Line 718:                 raise V2VProcessError('copy-disk stream closed unexpectedly')
Maybe use OuputParserError? seem more consistent with other errors raised in this class.
Line 719:             chunk += c
Line 720:             if c == '\r':
Line 721:                 yield chunk
Line 722:                 chunk = ''


-- 
To view, visit https://gerrit.ovirt.org/55477
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia166c1aa03a8d62168034cd581be80ef5a3dc69e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list