Change in vdsm[master]: v2v: fix handling virt-v2v fail on stream close

shavivi at redhat.com shavivi at redhat.com
Wed Mar 30 12:36:27 UTC 2016


Shahar Havivi has uploaded a new change for review.

Change subject: v2v: fix handling virt-v2v fail on stream close
......................................................................

v2v: fix handling virt-v2v fail on stream close

when proc.stdout.read() is close it doesn't raise an error but returns
''.

Change-Id: Ia166c1aa03a8d62168034cd581be80ef5a3dc69e
Url: https://bugzilla.redhat.com/1298134
Signed-off-by: Shahar Havivi <shaharh at redhat.com>
---
M lib/vdsm/v2v.py
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/77/55477/1

diff --git a/lib/vdsm/v2v.py b/lib/vdsm/v2v.py
index de0244b..bf2c436 100644
--- a/lib/vdsm/v2v.py
+++ b/lib/vdsm/v2v.py
@@ -714,6 +714,8 @@
         chunk = ''
         while True:
             c = stream.read(1)
+            if not c:
+                raise V2VProcessError('copy-disk stream closed unexpectedly')
             chunk += c
             if c == '\r':
                 yield chunk


-- 
To view, visit https://gerrit.ovirt.org/55477
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia166c1aa03a8d62168034cd581be80ef5a3dc69e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>


More information about the vdsm-patches mailing list