Change in vdsm[master]: storagetests: add a test for normalize_local_path

ishaby at redhat.com ishaby at redhat.com
Wed Mar 30 12:18:59 UTC 2016


Idan Shaby has posted comments on this change.

Change subject: storagetests: add a test for normalize_local_path
......................................................................


Patch Set 2: Verified-1

(1 comment)

Marking verified=-1 as for my note in storageServerTests.py.

https://gerrit.ovirt.org/#/c/55181/1/tests/storageServerTests.py
File tests/storageServerTests.py:

Line 66:         self.assertEquals(mount_con._mount.fs_spec, "dummy-spec")
Line 67:         self.assertEquals(mount_con._mount.fs_file, "/tmp/dummy-spec")
Line 68: 
Line 69:     @permutations([
Line 70:         # spec, localpath
> Please remove the @brokentest, until we are sure that the failures are caus
Removing the @brokentest.
Please *DO NOT* merge this patch until I bring back the @brokentest.
Line 71:         ("server:/a/", "/tmp/server:_a"),
Line 72:         ("server:/a//", "/tmp/server:_a"),
Line 73:         ("server:/a/b", "/tmp/server:_a_b"),
Line 74:         ("server:/a//b", "/tmp/server:_a_b"),


-- 
To view, visit https://gerrit.ovirt.org/55181
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e95c6b2bc214b7f3cc1e2d3ec164efecd67c14a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list