Change in vdsm[master]: virt: add device setup and teardown

fromani at redhat.com fromani at redhat.com
Wed Mar 30 12:16:36 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: virt: add device setup and teardown
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

one minor comment inside

https://gerrit.ovirt.org/#/c/55135/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:

PS2, Line 1689: dev_type
minor, but will ever need to use dev_type here?

maybe just

  for dev_object in self._devices.values():
     # ... do something


let's keep in mind that in py3 values() will return a view-like object, hence we must ensure the safety of the iteration.


PS2, Line 1866: dev_type
same


-- 
To view, visit https://gerrit.ovirt.org/55135
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f99b855de43cff693b99b6873a835b7ad56db1b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list