Change in vdsm[master]: net: native ovs [1]: ovs switch skeleton
phoracek at redhat.com
phoracek at redhat.com
Wed Mar 30 11:51:15 UTC 2016
Petr Horáček has posted comments on this change.
Change subject: net: native ovs [1]: ovs switch skeleton
......................................................................
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/55308/1/lib/vdsm/network/netswitch.py
File lib/vdsm/network/netswitch.py:
PS1, Line 45: if (('remove' in attrs and net in running_config.networks and
: ovs_switch.is_ovs_net(running_config.networks[net])) or
: ovs_switch.is_ovs_net(attrs)):
> great idea, all right
but i would do that only when we have defined 'legacy' attribute in API, until that it would be just extra handling in canonicalize.py
--
To view, visit https://gerrit.ovirt.org/55308
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic056fcf8c0d36625328a90a339d4a09658683056
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list