Change in vdsm[master]: hostdev: add support for hotplug

mpolednik at redhat.com mpolednik at redhat.com
Wed Mar 30 11:40:45 UTC 2016


Martin Polednik has posted comments on this change.

Change subject: hostdev: add support for hotplug
......................................................................


Patch Set 12:

(1 comment)

https://gerrit.ovirt.org/#/c/42661/12/lib/api/vdsmapi-schema.json
File lib/api/vdsmapi-schema.json:

PS12, Line 7711: hostdevHotplug
> Why do we need 2 times vmId? One is needed to construct VM object. Is the s
I'm torn. This is kind of our idiomatic approach and code expects the request to be packed in params (e.g. validateMinimalKey)


-- 
To view, visit https://gerrit.ovirt.org/42661
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2465360664ef9b659c52dc610a95d2c2f1555c54
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list