Change in vdsm[master]: vm: Move saveState() out of constructor

mbetak at redhat.com mbetak at redhat.com
Tue Mar 29 11:15:27 UTC 2016


Martin Betak has posted comments on this change.

Change subject: vm: Move saveState() out of constructor
......................................................................


Patch Set 6:

(1 comment)

https://gerrit.ovirt.org/#/c/53950/6/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 685:             if not acquired:
Line 686:                 self._vmAsyncStartError = response.error('migrateLimit')
Line 687:                 self._vmStartEvent.set()
Line 688:                 return
Line 689: 
> I'd rather move the saveState() here from line 668 here.
so essentially moving back where it was in first patchset :-)
Only difference I think it was originally *after* _vmStartEvent.set() so we just move it before, right?
Line 690:         self._vmStartEvent.set()
Line 691:         try:
Line 692:             self.memCommit()
Line 693:             with self._ongoingCreations:


-- 
To view, visit https://gerrit.ovirt.org/53950
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb38fdc06bf1a7b881cd64d2af45a93b16c935ea
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list