Change in vdsm[ovirt-3.6]: spec: build rhev with hooks

ybronhei at redhat.com ybronhei at redhat.com
Mon Mar 28 13:11:27 UTC 2016


Yaniv Bronhaim has posted comments on this change.

Change subject: spec: build rhev with hooks
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/55322/1/vdsm.spec.in
File vdsm.spec.in:

Line 18: 
Line 19: # RHEV build - overridable using rpmbuild --define "rhev_build 1"
Line 20: %{!?rhev_build: %global rhev_build 0}
Line 21: 
Line 22: %if 0%{fedora_koji_build} || 0 %{rhev_build}
> The value of with_hooks should come from configure. If you want to build wi
this is only in 3.6 which didn't get latest master backport in this area - we need to face what we currently have and fix it as quick and short as possible imo. I don't want to touch configure in stable branch and in this code tree --enable-hooks does nothing.
Line 23: %global with_hooks 1
Line 24: %endif
Line 25: 
Line 26: # Default to skipping autoreconf.  Distros can change just this one line


-- 
To view, visit https://gerrit.ovirt.org/55322
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I02deb713806ba3650ecc4dbe623a5fe2da10fa94
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list