Change in vdsm[master]: test: Use mock module for testing

ybronhei at redhat.com ybronhei at redhat.com
Mon Mar 28 12:42:50 UTC 2016


Yaniv Bronhaim has posted comments on this change.

Change subject: test: Use mock module for testing
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/55342/1/lib/vdsm/compat.py
File lib/vdsm/compat.py:

Line 50:     from unittest import mock
Line 51:     mock
Line 52: except ImportError:  # py2
Line 53:     import mock
Line 54:     mock
> mock has been added to the standard library for a good reason, it is a comp
ok. just move this import to testlib


-- 
To view, visit https://gerrit.ovirt.org/55342
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c0af7baab7c35a2617bd60a62a0b1534e5f8894
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list