Change in vdsm[master]: network: inherit DUID from a bridge's port with no restriction

osvoboda at redhat.com osvoboda at redhat.com
Mon Mar 28 08:27:09 UTC 2016


Ondřej Svoboda has posted comments on this change.

Change subject: network: inherit DUID from a bridge's port with no restriction
......................................................................


Patch Set 5:

(1 comment)

https://gerrit.ovirt.org/#/c/54130/5/lib/vdsm/network/configurators/dhclient.py
File lib/vdsm/network/configurators/dhclient.py:

PS5, Line 134: subprocess
> Bypassing execCmd here seems like a hack, I'm not sure if we know what we a
All I found about dhcpctl was that it was "a set of functions to control the dhcp server". Anyway, I don't think we want to tie ourselves to the one DHCP client any more than we already do.

I reacted to Popen/CPopen elsewhere.


-- 
To view, visit https://gerrit.ovirt.org/54130
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id86f3afc20562ca670370b2e2907d46ae2203900
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list