Change in vdsm[master]: network: inherit DUID from a bridge's port with no restriction

edwardh at redhat.com edwardh at redhat.com
Mon Mar 28 06:56:39 UTC 2016


Edward Haas has posted comments on this change.

Change subject: network: inherit DUID from a bridge's port with no restriction
......................................................................


Patch Set 5: Code-Review+1 Verified+1

(1 comment)

Verified on Centos7 (unit & functional net tests)

https://gerrit.ovirt.org/#/c/54130/5/lib/vdsm/network/configurators/dhclient.py
File lib/vdsm/network/configurators/dhclient.py:

PS5, Line 134: subprocess
Bypassing execCmd here seems like a hack, I'm not sure if we know what we are 'loosing' here. (I think execCmd handled several limitations and problems with Popen in Python2)

It would have been nicer and safer to add a 'silent'/'verbose' flag to execCmd.
But as this detection method is ugly by itself, maybe it does not matter much.

For the long run,  I would suggest using dhcpctl to query and control dhclient.


-- 
To view, visit https://gerrit.ovirt.org/54130
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id86f3afc20562ca670370b2e2907d46ae2203900
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list