Change in vdsm[master]: image: add a flag for preparing with illegal volumes.

nsoffer at redhat.com nsoffer at redhat.com
Sun Mar 27 16:09:03 UTC 2016


Nir Soffer has posted comments on this change.

Change subject: image: add a flag for preparing with illegal volumes.
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/55199/2/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:

Line 3192:             if legality == volume.ILLEGAL_VOL:
Line 3193:                 if allowIllegal:
Line 3194:                     self.log.info("Preparing illegal volume %s", leafUUID)
Line 3195:                 else:
Line 3196:                     raise se.prepareIllegalVolumeError(volUUID)
This works, but unfortunately, it does not protect old vdsm versions. The legality check was added in 4.0 and older version version do not check this when starting a vm.

So we should rethink what is the best way to define image as unsafe, and it can work only for domain version 4 in the next release.
Line 3197: 
Line 3198:         imgPath = dom.activateVolumes(imgUUID, imgVolumes)
Line 3199:         if spUUID and spUUID != sd.BLANK_UUID:
Line 3200:             runImgPath = dom.linkBCImage(imgPath, imgUUID)


-- 
To view, visit https://gerrit.ovirt.org/55199
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie18ab167635e6e099c3a12e03ea6620578c3103f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list