Change in vdsm[master]: storage: Move mount module to vdsm storage lib

nsoffer at redhat.com nsoffer at redhat.com
Sun Mar 27 15:56:31 UTC 2016


Nir Soffer has posted comments on this change.

Change subject: storage:  Move mount module to vdsm storage lib
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

We cannot move mount.py since it depends on misc.py. We have to move misc.py first.

I suggest to wait with the moves, and first organize imports in all storage modules, since it is very hard to understand dependencies with the current mess.

https://gerrit.ovirt.org/#/c/55292/1/vdsm/storage/blockSD.py
File vdsm/storage/blockSD.py:

Line 35
Line 36
Line 37
Line 38
Line 39
The mount import should be here.


Line 51: from resourceFactories import LVM_ACTIVATION_NAMESPACE
Line 52: import iscsi
Line 53: from storage_mailbox import MAILBOX_SIZE
Line 54: import resourceManager as rm
Line 55: import vdsm.storage.mount
Unlike java, this does not work - it create the name "vdsm.storage.mount" instead of "mount", so all the code working with "mount" will fail.

This should be:

    from vdsm.storage import mount

And it should be need the other "from vdsm.storage" mounts.
Line 56: import volume
Line 57: 
Line 58: STORAGE_DOMAIN_TAG = "RHAT_storage_domain"
Line 59: STORAGE_UNREADY_DOMAIN_TAG = STORAGE_DOMAIN_TAG + "_UNREADY"


-- 
To view, visit https://gerrit.ovirt.org/55292
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8ee9fab87abcabc469c15256ba12386112a100e0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list