Change in vdsm[master]: Kill and report asyncProc if fails on first write to stdin

nsoffer at redhat.com nsoffer at redhat.com
Sun Mar 27 12:49:41 UTC 2016


Nir Soffer has posted comments on this change.

Change subject: Kill and report asyncProc if fails on first write to stdin
......................................................................


Patch Set 6:

Yaniv, sync is not standard subprocess.Popen parameter, and we should remove it anyway, so there is no need to support sync + data.

There should be two ways to run commands:

- commands.run_command() - like subprocess.check_call, call command, communicate with it, and return the rc, out, err. Most of the code can use this.

- commands.start_command() - create subprocess.Popen with the proper wrapping and return the command. The user is responsible for writing to command stdin and reading from stdout/err.

Having one entry point with too many parameters and confusing behavior like we have now does not help anyone.

-- 
To view, visit https://gerrit.ovirt.org/51763
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I57b68742ce1dcae1d9fdad020b7b4a41ca6ad028
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: No


More information about the vdsm-patches mailing list