Change in vdsm[master]: storagetests: add tests for mounting domains

nsoffer at redhat.com nsoffer at redhat.com
Sun Mar 27 12:09:09 UTC 2016


Nir Soffer has posted comments on this change.

Change subject: storagetests: add tests for mounting domains
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/55181/1/tests/storageServerTests.py
File tests/storageServerTests.py:

Line 66:         mount_con = MountConnection("dummy-spec", mountClass=FakeMount)
Line 67:         self.assertEquals(mount_con._mount.fs_spec, "dummy-spec")
Line 68:         self.assertEquals(mount_con._mount.fs_file, "/tmp/dummy-spec")
Line 69: 
Line 70:     @brokentest
Please remove the @brokentest, until we are sure that the failures are caused by wrong code and not wrong tests.

I want to see the failures easily, @brokentest hides the errors.
Line 71:     @permutations([
Line 72:         # spec, localpath
Line 73:         ("server:/a/", "/tmp/server:_a"),
Line 74:         ("server:/a//", "/tmp/server:_a"),


-- 
To view, visit https://gerrit.ovirt.org/55181
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e95c6b2bc214b7f3cc1e2d3ec164efecd67c14a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list