Change in vdsm[master]: ensure proc terminatation after poll

ybronhei at redhat.com ybronhei at redhat.com
Sun Mar 27 11:22:15 UTC 2016


Yaniv Bronhaim has posted comments on this change.

Change subject: ensure proc terminatation after poll
......................................................................


Patch Set 1:

(1 comment)

please ack - unless you have any better suggestion for testing it

https://gerrit.ovirt.org/#/c/52670/1/lib/vdsm/commands.py
File lib/vdsm/commands.py:

Line 95:         if not raw:
Line 96:             out = out.splitlines(False)
Line 97:             err = err.splitlines(False)
Line 98: 
Line 99:         return p.returncode, out, err
we don't need to test anything here - mocking communicate to raise exception and mock cpopen to keep the pid and then check that after the "with" scope the pid doesn't not exist - all redundant - we have tests for "teminating" decorator which covers this usage and writing such mocking magic is not useful for anything
Line 100: 
Line 101: 
Line 102: class AsyncProc(object):
Line 103:     """


-- 
To view, visit https://gerrit.ovirt.org/52670
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9bbd07bf33109315f4ea6b9fc2d629163f6696da
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list