Change in vdsm[ovirt-3.6.3]: blockVolume: Remove stale links to image directory

ybronhei at redhat.com ybronhei at redhat.com
Sun Mar 27 10:37:20 UTC 2016


Yaniv Bronhaim has submitted this change and it was merged.

Change subject: blockVolume: Remove stale links to image directory
......................................................................


blockVolume: Remove stale links to image directory

Since we started to create the image directory under "/run/vdsm", the
image directory under "/rhev/data-center/pool/sd/images/" may be a link
to "/run/vdsm/storage/sd/image".

The old code (from rhev-3.0) creating the image directory lazily was not
designed to handle links and was happily using a stale link instead of
creating the image directory.

Now we detect and remove stale links, so proper image directory is
created. Since stale links are not expected in normal usage, we log a
warning in this case.

Change-Id: Ic694caab0e030c675e4a3a0c0638298abfea1a8c
Bug-Url: https://bugzilla.redhat.com/1321444
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
Signed-off-by: Adam Litke <alitke at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/55231
Continuous-Integration: Jenkins CI
Reviewed-by: Francesco Romani <fromani at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/55285
Tested-by: Allon Mureinik <amureini at redhat.com>
Reviewed-by: Yaniv Bronhaim <ybronhei at redhat.com>
Continuous-Integration: Yaniv Bronhaim <ybronhei at redhat.com>
---
M vdsm/storage/blockVolume.py
1 file changed, 8 insertions(+), 0 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, but someone else must approve
  Yaniv Bronhaim: Looks good to me, approved; Passed CI tests
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/55285
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic694caab0e030c675e4a3a0c0638298abfea1a8c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6.3
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the vdsm-patches mailing list