Change in vdsm[master]: jsonrpcvdscli: add storage verbs

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Fri Mar 25 15:55:05 UTC 2016


Piotr Kliczewski has posted comments on this change.

Change subject: jsonrpcvdscli: add storage verbs
......................................................................


Patch Set 1:

It looks like hsm makes them optional:

    @public
    def createStoragePool(self, poolType, spUUID, poolName, masterDom,
                          domList, masterVersion, lockPolicy=None,
                          lockRenewalIntervalSec=None, leaseTimeSec=None,
                          ioOpTimeoutSec=None, leaseRetries=None,
                          options=None):

not sure why they are defined as required on API.py level.

-- 
To view, visit https://gerrit.ovirt.org/55252
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2066afcbc8e7cac6a9ed534b2bb4034ea0fd854
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: No


More information about the vdsm-patches mailing list