Change in vdsm[master]: ifcfg: re-enable IPv6 before device configuration, or disabl...

osvoboda at redhat.com osvoboda at redhat.com
Fri Mar 25 09:59:15 UTC 2016


Ondřej Svoboda has posted comments on this change.

Change subject: ifcfg: re-enable IPv6 before device configuration, or disable afterwards
......................................................................


Patch Set 12:

(4 comments)

https://gerrit.ovirt.org/#/c/54555/12/lib/vdsm/network/configurators/__init__.py
File lib/vdsm/network/configurators/__init__.py:

PS12, Line 214: ipv6_supported
> We seem to need this only when enable=False.
Good point. We better not be silent when the user orders to set up an IPv6 network on a system where it is not possible. So I extracted the condition out.


PS12, Line 227: logging.warning
> Do we really need it? Won't we explode if something unexpected will happen?
I am afraid I don't follow you.

If you question the purpose of the context manager, well, the code touching possibly inexistent sysctl nodes is more likely to explode, unlike other parts of ifcfg, which delegates dirty work to initscripts.

But I cannot recall if this in fact protects us more from actually missing devices or from the missing /proc/sys/net/ipv6 tree.


https://gerrit.ovirt.org/#/c/54555/12/tests/functional/networkTests.py
File tests/functional/networkTests.py:

PS12, Line 1888: @cleanupNet
> Just checking with you: If the test fail, do we see the correct backtrace? 
This is how the test would fail before https://gerrit.ovirt.org/#/c/55078/ was merged. We can see both the inner and the outer function in the backtrace.

No dummies were left over after the tests.

[root at localhost tests]# cd /usr/share/vdsm/tests/; ip link del dev bond0; NOSE_TESTMATCH='test_setupNetworks_swap_slaves_between_bonds|test_static_ip_configuration_' ./run_tests.sh --enable-slow-tests functional/networkTests.py
Cannot find device "bond0"
nose.config: INFO: Ignoring files matching ['^\\.', '^_', '^setup\\.py$']
functional.networkTests.NetworkTest
    test_setupNetworks_swap_slaves_between_bonds                OK
    test_static_ip_configuration_dual_to_v4                     FAIL
    test_static_ip_configuration_dual_to_v6_and_back            OK
    test_static_ip_configuration_v4_to_dual                     OK

======================================================================
FAIL: test_static_ip_configuration_dual_to_v4 (functional.networkTests.NetworkTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/share/vdsm/tests/functional/networkTests.py", line 1883, in test_static_ip_configuration_dual_to_v4
    self._test_static_ip_configuration(([4, 6], [4]))
  File "/usr/share/vdsm/tests/functional/networkTests.py", line 213, in wrapper
    func(*args, **kwargs)
  File "/usr/share/vdsm/tests/functional/networkTests.py", line 1926, in _test_static_ip_configuration
    change_ip_configuration_and_verify(ip_families)
  File "/usr/share/vdsm/tests/functional/networkTests.py", line 1909, in change_ip_configuration_and_verify
    self.assertEqual(status, SUCCESS, msg)
AssertionError: Nic dummy_w13LD already enslaved to bond1
-------------------- >> begin captured logging << --------------------
root: DEBUG: /usr/bin/taskset --cpu-list 0-0 /usr/sbin/tc qdisc show (cwd None)
root: DEBUG: SUCCESS: <err> = ''; <rc> = 0
root: INFO: Adding bond0({'nics': ['dummy_YIvgK', 'dummy_gPt3w'], 'options': 'mode=0'})
root: INFO: Adding bond1({'nics': ['dummy_mN94G', 'dummy_w13LD'], 'options': 'mode=0'})
SuperVdsmProxy: DEBUG: Trying to connect to Super Vdsm
--------------------- >> end captured logging << ---------------------

----------------------------------------------------------------------
Ran 4 tests in 48.035s

FAILED (failures=1)


PS12, Line 1889: _test_static_ip_configuration
> Thanks, now I understand what is actually tested.
I haven't seen the helper running: what matters is the 'test' prefix.


-- 
To view, visit https://gerrit.ovirt.org/54555
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idddfb096e6ea384dbe6655c5c4178d4884a8db85
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list