Change in vdsm[master]: vm: use the new response handling

fromani at redhat.com fromani at redhat.com
Fri Mar 25 09:27:09 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: vm: use the new response handling
......................................................................


Patch Set 8:

(2 comments)

https://gerrit.ovirt.org/#/c/54799/8//COMMIT_MSG
Commit Message:

Line 6: 
Line 7: vm: use the new response handling
Line 8: 
Line 9: Let's start using the new api.method
Line 10: decoratore to handle exceptions and response
> decorator
Thanks, fixed
Line 11: from few methods already in need of some
Line 12: refactoring and cleanup.
Line 13: 
Line 14: Change-Id: Ib594a5cc6cd8945c24cfcb3704ad92d02102993b


Line 8: 
Line 9: Let's start using the new api.method
Line 10: decoratore to handle exceptions and response
Line 11: from few methods already in need of some
Line 12: refactoring and cleanup.
> So this changes random apis? Why not wrap all apis?
Not random: I'm starting from the APIs which most need a cleanup.

I agree we must do transition, but I'll like to do in a small steps, to make things easily testable
Line 13: 
Line 14: Change-Id: Ib594a5cc6cd8945c24cfcb3704ad92d02102993b


-- 
To view, visit https://gerrit.ovirt.org/54799
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib594a5cc6cd8945c24cfcb3704ad92d02102993b
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list