Change in vdsm[master]: vm: safer early return if destroyed on startup

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Fri Mar 25 08:48:56 UTC 2016


Piotr Kliczewski has posted comments on this change.

Change subject: vm: safer early return if destroyed on startup
......................................................................


Patch Set 4:

(2 comments)

https://gerrit.ovirt.org/#/c/55151/4//COMMIT_MSG
Commit Message:

PS4, Line 17: This patch improves that check to reduce the
            : time destroy()
I do not see here info about 30 sec timeout we introduce here before calling destroy logic.


https://gerrit.ovirt.org/#/c/55151/4/vdsm/virt/vm.py
File vdsm/virt/vm.py:

PS4, Line 3898: wait(_DESTROY_STARTUP_TIMEOUT)
Does it mean that we may block api call for 30 seconds?

Wouldn't be better to do it in async way?


-- 
To view, visit https://gerrit.ovirt.org/55151
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I618eb03783d7059ae33d7b0a02542b99c8d8199b
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list