Change in vdsm[master]: spec: don't depend on ovirt-vmconsole on fedora

fromani at redhat.com fromani at redhat.com
Thu Mar 24 16:43:57 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: spec: don't depend on ovirt-vmconsole on fedora
......................................................................


Patch Set 6:

(3 comments)

https://gerrit.ovirt.org/#/c/54999/6//COMMIT_MSG
Commit Message:

Line 7: spec: don't depend on ovirt-vmconsole on fedora
Line 8: 
Line 9: Resurrect the koji_build flag to avoid to depend
Line 10: on ovirt-vmconsole on fedora, where the package
Line 11: is not yet present.
> update the commit msg as well
Done
Line 12: 
Line 13: Should Vdsm be installed on a system on which the
Line 14: ovirt-vmconsole package is not installed, it must
Line 15: be ./configure'd with those two options:


https://gerrit.ovirt.org/#/c/54999/6/configure.ac
File configure.ac:

Line 91:     )],
Line 92:     ,
Line 93:     [enable_ovirt_vmconsole="yes"]
Line 94: )
Line 95: AS_IF([test "${enable_ovirt_vmconsole}" = "yes"],
> you configure only --enable-ovirt-vmconsole and you use --disable.. you nee
will switch the names
Line 96:       AC_SUBST([OVIRT_VMCONSOLE], ['1']),
Line 97:       AC_SUBST([OVIRT_VMCONSOLE], ['0']))
Line 98: 
Line 99: AC_ARG_ENABLE(


https://gerrit.ovirt.org/#/c/54999/6/vdsm.spec.in
File vdsm.spec.in:

Line 657: %endif
Line 658:         --with-smbios-manufacturer='@SMBIOS_MANUFACTURER@' \
Line 659:         --with-smbios-osname='@SMBIOS_OSNAME@' \
Line 660: %if ! 0%{?with_ovirt_vmconsole}
Line 661: 	--with-ovirt-vmconsole-user='@VDSMUSER@' \
> remove tabs
Done
Line 662: 	--with-ovirt-vmconsole-group='@VDSMGROUP@' \
Line 663: %endif
Line 664:         --with-qemu-kvm='@QEMU_KVM_PKG@' \
Line 665:         --with-qemu-img='@QEMU_IMG_PKG@'


-- 
To view, visit https://gerrit.ovirt.org/54999
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I81d39abcc55e371ac3631b0d5394ebf174c86fee
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list