Change in vdsm[master]: fileUtils: tarCopy - avoid extracting the file modified time

laravot at redhat.com laravot at redhat.com
Thu Mar 24 08:45:28 UTC 2016


Liron Aravot has posted comments on this change.

Change subject: fileUtils: tarCopy - avoid extracting the file modified time
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/55163/1/vdsm/storage/fileUtils.py
File vdsm/storage/fileUtils.py:

Line 60: 
Line 61:     tsrc = subprocess.Popen([constants.EXT_TAR, "cf", "-"] +
Line 62:                             excludeArgs + ["-C", src, "."],
Line 63:                             stdout=subprocess.PIPE)
Line 64:     tdst = subprocess.Popen([constants.EXT_TAR, "xf", "-", "-C", dst, "-m"],
> Can you use the long option (--touch) instead?  It is easier to debug code 
Done
Line 65:                             stdin=tsrc.stdout, stderr=subprocess.PIPE,
Line 66:                             stdout=subprocess.PIPE)
Line 67:     tsrc.stdout.close()
Line 68:     out, err = tdst.communicate()


-- 
To view, visit https://gerrit.ovirt.org/55163
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I97e937aac233958db52b2fda685f5a5964fda2c8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list