Change in vdsm[master]: virt: add device setup and teardown

nsoffer at redhat.com nsoffer at redhat.com
Wed Mar 23 18:26:54 UTC 2016


Nir Soffer has posted comments on this change.

Change subject: virt: add device setup and teardown
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/55135/1/vdsm/virt/vmdevices/core.py
File vdsm/virt/vmdevices/core.py:

Line 82:         pass
Line 83: 
Line 84:     def teardown(self):
Line 85:         """
Line 86:         Actions to be executed before VM is destroyed.
Before? I think this is after a vm is destroyed - you cannot change the permissions of a device before destroying the vm, right?
Line 87:         """
Line 88:         pass
Line 89: 
Line 90: 


-- 
To view, visit https://gerrit.ovirt.org/55135
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f99b855de43cff693b99b6873a835b7ad56db1b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list