Change in vdsm[master]: net: Adding the netswitch module

phoracek at redhat.com phoracek at redhat.com
Wed Mar 23 14:34:14 UTC 2016


Petr Horáček has posted comments on this change.

Change subject: net: Adding the netswitch module
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/55131/1/lib/vdsm/network/api.py
File lib/vdsm/network/api.py:

Line 246: 
Line 247:     logging.debug('Applying...')
Line 248:     in_rollback = options.get('_inRollback', False)
Line 249:     with _rollback():
Line 250:         for switch in netswitch.switches():
i don't think, that simple iteration will work with multiple switches. i'd drop it for now. later we have to introduce mixing checker and then setup one switch OR do that special removal and setup with two nested rollbacks.
Line 251:             netswitch.setup(switch, networks, bondings, in_rollback)
Line 252:             _check_connectivity(networks, bondings, options)
Line 253: 
Line 254: 


-- 
To view, visit https://gerrit.ovirt.org/55131
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I869e634e9f97cf279d4df83fca2b8f8d73bcea47
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list