Change in vdsm[master]: utils: suppress

danken at redhat.com danken at redhat.com
Wed Mar 23 11:56:31 UTC 2016


Dan Kenigsberg has posted comments on this change.

Change subject: utils: suppress
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/55065/2/lib/vdsm/utils.py
File lib/vdsm/utils.py:

Line 918:     return wrapper
Line 919: 
Line 920: 
Line 921: @contextmanager
Line 922: def suppress(exception=Exception):
please have the same signature as that of python3's contextmanager.

please import the standard lib contextmanager if the python interpreter is >= 3.4
Line 923:     """ Python 3 suppress context manager.
Line 924: 
Line 925:     https://docs.python.org/3/library/contextlib.html#contextlib.suppress
Line 926:     """


-- 
To view, visit https://gerrit.ovirt.org/55065
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I76d5b0658435e59701ac4d845827e86026085c07
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list