Change in vdsm[master]: vm: improve safety between startup and shutdown
mpolednik at redhat.com
mpolednik at redhat.com
Wed Mar 23 11:22:49 UTC 2016
Martin Polednik has posted comments on this change.
Change subject: vm: improve safety between startup and shutdown
......................................................................
Patch Set 6: Code-Review+1
(2 comments)
Commented PS#5, would still like answers. Nothing block worthy imo.
https://gerrit.ovirt.org/#/c/44989/5/vdsm/virt/vm.py
File vdsm/virt/vm.py:
PS5, Line 90: _DESTROY_ON_STARTUP_TIMEOUT = 30 # seconds
Arbitrary or backed up?
PS5, Line 192: class DestroyedOnStartupError(Exception):
: """
: Domain destroyed during startup process.
: """
(not related to *this* patch) do we have plans to move the exceptions to their module?
--
To view, visit https://gerrit.ovirt.org/44989
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8718f58f1d255d9e603db75aa1f256c03c300f3a
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list