Change in vdsm[master]: vm: improve safety between startup and shutdown

fromani at redhat.com fromani at redhat.com
Wed Mar 23 11:16:51 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: vm: improve safety between startup and shutdown
......................................................................


Patch Set 5:

(2 comments)

https://gerrit.ovirt.org/#/c/44989/5/lib/api/vdsmapi-schema.json
File lib/api/vdsmapi-schema.json:

PS5, Line 7051:  
> We do not need this space here.
Thanks, will fix both.


https://gerrit.ovirt.org/#/c/44989/5/lib/vdsm/virt/vmexitreason.py
File lib/vdsm/virt/vmexitreason.py:

PS5, Line 46: ,
> In old version we had no comma at the end. Do we need it now?
could make things easier for future updates, but no big deal


-- 
To view, visit https://gerrit.ovirt.org/44989
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8718f58f1d255d9e603db75aa1f256c03c300f3a
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list