Change in vdsm[master]: virt: set correct permissions for hwrng device

mpolednik at redhat.com mpolednik at redhat.com
Wed Mar 23 11:10:08 UTC 2016


Martin Polednik has posted comments on this change.

Change subject: virt: set correct permissions for hwrng device
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/54806/4/vdsm/supervdsm_api/udev.py
File vdsm/supervdsm_api/udev.py:

Line 84:         cmd = [EXT_CHOWN, 'root:root', _HWRNG_PATH]
Line 85:         rc, out, err = commands.execCmd(cmd)
Line 86:         if err:
Line 87:             raise OSError(errno.EINVAL, 'Could not change ownership'
Line 88:                           'out %s\nerr %s' % (out, err))
> Are we using this logic for other rules? This looks like generic function t
Currently shared between this and USB (since it's based on it). It could be reused, but I don't feel it being part of this patch.

There is quite a bit of duplication going on in this module that needs to be reduced (unfortunately caused by me).
Line 89: 
Line 90: 
Line 91: @expose
Line 92: def appropriateMultipathDevice(guid, thiefId):


-- 
To view, visit https://gerrit.ovirt.org/54806
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id958a291e5a15813309928ba3d8c67828273b6c6
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list