Change in vdsm[master]: hostdev: expose 'driver' attribute

mpolednik at redhat.com mpolednik at redhat.com
Wed Mar 23 10:26:09 UTC 2016


Martin Polednik has posted comments on this change.

Change subject: hostdev: expose 'driver' attribute
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.ovirt.org/#/c/55044/2/lib/vdsm/hostdev.py
File lib/vdsm/hostdev.py:

PS2, Line 128: devXML.find('./driver/name')
> if this is missing then devXML.find() returns None IIRC.
I feel that it is not *too* generic in this case (as it is trying to access attribute of NoneType) and goes well with EAFP. I'm fine changing it though.


https://gerrit.ovirt.org/#/c/55044/2/tests/hostdevTests.py
File tests/hostdevTests.py:

Line 128:             </vlan>
Line 129:             <boot order="9"/>
Line 130:             <driver name="vfio"/>
Line 131:     </interface>
Line 132:     '''}
> do we have one negative test? - e.g. driver NOT reported.
Actually not in these tests (as they are based on real machine), should be easy to hack one out. :)
Line 133: 
Line 134: DEVICES_PARSED = {u'pci_0000_00_1b_0': {'product': '6 Series/C200 Series '
Line 135:                                         'Chipset Family High Definition '
Line 136:                                         'Audio Controller',


-- 
To view, visit https://gerrit.ovirt.org/55044
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I81463100dd07a2bc4fb241f89581db2060b8982e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list