Change in vdsm[master]: net: native ovs [3], ip handling
edwardh at redhat.com
edwardh at redhat.com
Wed Mar 23 08:47:15 UTC 2016
Edward Haas has posted comments on this change.
Change subject: net: native ovs [3], ip handling
......................................................................
Patch Set 8:
(2 comments)
https://gerrit.ovirt.org/#/c/54930/8/lib/vdsm/network/ovs_switch/ip.py
File lib/vdsm/network/ovs_switch/ip.py:
PS8, Line 30: IPv4, IPv6
> We need to take these out to network.ip.address
https://gerrit.ovirt.org/#/c/55043
PS8, Line 41: top_dev
> I'm not clear on what is the difference between top_dev and port, could you
OK, so what about top_iface and base_iface?
Even more crazy: north_iface and south_iface :)
In any case, it should be described in the definition.
--
To view, visit https://gerrit.ovirt.org/54930
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie562fa5fb53c69fec85c8b368dbb5479d13dd473
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list