Change in vdsm[master]: hostdev: add support for hotunplug

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Tue Mar 22 15:25:05 UTC 2016


Piotr Kliczewski has posted comments on this change.

Change subject: hostdev: add support for hotunplug
......................................................................


Patch Set 6: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/42747/6/lib/api/vdsmapi-schema.json
File lib/api/vdsmapi-schema.json:

Line 7743: hostdevHotunplug
Why do we need 2 times vmId? One is needed to construct VM object. Is the second vmId different form params parameter?

Why not to reuse vmId passed during construction of VM object.


-- 
To view, visit https://gerrit.ovirt.org/42747
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If36f7da8f018615b76a1a8779ff15b890a823db8
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list