Change in vdsm[master]: ifcfg: re-enable IPv6 before device configuration, or disabl...

osvoboda at redhat.com osvoboda at redhat.com
Tue Mar 22 12:34:47 UTC 2016


Ondřej Svoboda has posted comments on this change.

Change subject: ifcfg: re-enable IPv6 before device configuration, or disable afterwards
......................................................................


Patch Set 9:

(1 comment)

https://gerrit.ovirt.org/#/c/54555/9/lib/vdsm/network/configurators/__init__.py
File lib/vdsm/network/configurators/__init__.py:

Line 216: wait_for_device
> I don't understand this one.
This is nothing new. I remember back when adding disable_ipv6 initially that even bridges, just the links, took some time to show up in the system. Let me try to remove the waiting and run tests locally.

I think that moving the delay somewhere else would just complicate things. Here, the logic is all in one place.

If the device already exists then wait_for_device return immediately.


-- 
To view, visit https://gerrit.ovirt.org/54555
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idddfb096e6ea384dbe6655c5c4178d4884a8db85
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list