Change in vdsm[master]: tests: refactor manifest_tests fake env setup

nsoffer at redhat.com nsoffer at redhat.com
Tue Mar 22 09:30:19 UTC 2016


Nir Soffer has submitted this change and it was merged.

Change subject: tests: refactor manifest_tests fake env setup
......................................................................


tests: refactor manifest_tests fake env setup

The manifest_tests have a lot of boilerplate code to set up the fake
environment for each test.  Use the new FakeEnv infrastructure provided
by storagetestlib to clean up these tests.

Change-Id: I74b82ffaa34d6df68e1531735cc776e4de23f95c
Signed-off-by: Adam Litke <alitke at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/50273
Continuous-Integration: Jenkins CI
Reviewed-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-by: Freddy Rolland <frolland at redhat.com>
---
M tests/domain_manifest_test.py
1 file changed, 72 insertions(+), 100 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, approved
  Adam Litke: Verified
  Jenkins CI: Passed CI tests
  Freddy Rolland: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/50273
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I74b82ffaa34d6df68e1531735cc776e4de23f95c
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the vdsm-patches mailing list