Change in vdsm[master]: virt: set correct permissions for hwrng device
nsoffer at redhat.com
nsoffer at redhat.com
Tue Mar 22 09:27:37 UTC 2016
Nir Soffer has posted comments on this change.
Change subject: virt: set correct permissions for hwrng device
......................................................................
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/54806/4/vdsm/virt/vmdevices/core.py
File vdsm/virt/vmdevices/core.py:
Line 392:
Line 393: def uses_source(self, source):
Line 394: return self._SOURCES[self.specParams['source']] == source
Line 395:
Line 396: def set_endpoint_permissions(self):
> I like the idea of setup/teardown, will play nice with hotplug/hotunplung a
Generic setup/teardown for all devices sounds good, and then we can drop this specific device method. Until we have that this looks ok, although I don't understand the "endpoint" thing - why not (set/unset)_permissions()?
Line 397: supervdsm.getProxy().appropriateHwrngDevice(self.conf['vmId'])
Line 398:
Line 399: def unset_endpoint_permissions(self):
Line 400: supervdsm.getProxy().rmAppropriateHwrngDevice(self.conf['vmId'])
--
To view, visit https://gerrit.ovirt.org/54806
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id958a291e5a15813309928ba3d8c67828273b6c6
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list