Change in vdsm[master]: virt: common handling of exceptions

nsoffer at redhat.com nsoffer at redhat.com
Mon Mar 21 19:26:07 UTC 2016


Nir Soffer has posted comments on this change.

Change subject: virt: common handling of exceptions
......................................................................


Patch Set 11:

(1 comment)

https://gerrit.ovirt.org/#/c/54664/11/tests/virt_api_test.py
File tests/virt_api_test.py:

Line 17: #
Line 18: # Refer to the README and COPYING files for full details of the license
Line 19: #
Line 20: 
Line 21: from vdsm.virt import api
I think this should come after vdsm imports (more specific), or even last - this is the module under test.
Line 22: from vdsm import exception
Line 23: from vdsm import response
Line 24: 
Line 25: from testlib import VdsmTestCase as TestCaseBase


-- 
To view, visit https://gerrit.ovirt.org/54664
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic186dc8fa062d8b3789c6057bba68fbbc23f311b
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list