Change in vdsm[master]: hostdev: expose generic scsi driver char device in device pa...

mpolednik at redhat.com mpolednik at redhat.com
Mon Mar 21 17:32:19 UTC 2016


Martin Polednik has uploaded a new change for review.

Change subject: hostdev: expose generic scsi driver char device in device params
......................................................................

hostdev: expose generic scsi driver char device in device params

Preparation for upcoming scsi-passthrough patch series. This value can
be displayed by engine for better UX as it corresponds to generic scsi
driver device names (e.g. /dev/sg{num}). Main reason is that VDSM needs
to know the endpoint to properly set permissions.

Change-Id: I91e6793e946310b57e3004cbebc286cc6e00a724
Signed-off-by: Martin Polednik <mpolednik at redhat.com>
---
M lib/vdsm/hostdev.py
1 file changed, 6 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/22/55022/1

diff --git a/lib/vdsm/hostdev.py b/lib/vdsm/hostdev.py
index 48933b6..c9371eb 100644
--- a/lib/vdsm/hostdev.py
+++ b/lib/vdsm/hostdev.py
@@ -141,6 +141,12 @@
         address = physfn.find('address')
         params['physfn'] = pci_address_to_name(**address.attrib)
 
+    try:
+        params['endpoint'] = caps.find('char').text
+    except AttributeError:
+        # Is not scsi endpoint.
+        pass
+
     iommu_group = caps.find('iommuGroup')
     if iommu_group is not None:
         params['iommu_group'] = iommu_group.attrib['number']


-- 
To view, visit https://gerrit.ovirt.org/55022
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I91e6793e946310b57e3004cbebc286cc6e00a724
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>


More information about the vdsm-patches mailing list