Change in vdsm[master]: virt: set correct permissions for hwrng device

fromani at redhat.com fromani at redhat.com
Mon Mar 21 17:03:27 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: virt: set correct permissions for hwrng device
......................................................................


Patch Set 4: Code-Review+1

(1 comment)

partial review: I just need to deep dive of udev handling and refresh my knowledge. Looks good so far, hence partial ACK.

https://gerrit.ovirt.org/#/c/54806/4/vdsm/supervdsm_api/udev.py
File vdsm/supervdsm_api/udev.py:

Line 70: _udevTrigger
we do this already for other subsystem, AFAIR it's as race-free as we could get, right?


-- 
To view, visit https://gerrit.ovirt.org/54806
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id958a291e5a15813309928ba3d8c67828273b6c6
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list