Change in vdsm[master]: contrib: schema converter

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Mon Mar 21 15:08:43 UTC 2016


Piotr Kliczewski has posted comments on this change.

Change subject: contrib: schema converter
......................................................................


Patch Set 23:

(5 comments)

https://gerrit.ovirt.org/#/c/52864/23/contrib/schema-converter
File contrib/schema-converter:

Line 26: json_schema_path - path where json schema is located
Line 27: 
Line 28: yaml_schema_path - path where yaml schema is written
Line 29: """
Line 30: from api import vdsmapi
> Should be at the end of the imports as ths is the most specific import.
I am not importing it from current package so I can use '.'.

Will keep the import ordering tidy.
Line 31: 
Line 32: import sys
Line 33: import yaml
Line 34: 


Line 29: """
Line 30: from api import vdsmapi
Line 31: 
Line 32: import sys
Line 33: import yaml
> This is not from standard library, so it should be after the collections im
Done
Line 34: 
Line 35: from collections import OrderedDict
Line 36: 
Line 37: 


https://gerrit.ovirt.org/#/c/52864/23/lib/api/Makefile.am
File lib/api/Makefile.am:

Line 31: 	$(NULL)
Line 32: 
Line 33: dist_vdsmpyrpc_PYTHON = \
Line 34: 	__init__.py \
Line 35: 	schemaapi.py\
> Can we rename this to schema.py?
We are in removal old schemas patch and we reuse vdsmapi module name.
Line 36: 	vdsmapi.py \
Line 37: 	$(NULL)
Line 38: 
Line 39: dist_vdsmrpc_DATA = \


https://gerrit.ovirt.org/#/c/52864/23/lib/api/process-schema.py
File lib/api/process-schema.py:

Line 36
Line 37
Line 38
Line 39
Line 40
> Instead of moving this code, rename the module to process_schema.py, or bet
Done


https://gerrit.ovirt.org/#/c/52864/23/vdsm.spec.in
File vdsm.spec.in:

Line 79: BuildRequires: python-pthreading
Line 80: BuildRequires: qemu-img
Line 81: BuildRequires: rpm-python
Line 82: BuildRequires: python-blivet
Line 83: BuildRequires: python-yaml
> What about python3-yaml?
I can only see:

BuildRequires: python3-nose
BuildRequires: python3-six

and there are no other module dependencies with python3. Do we really want to add it now?
Line 84: 
Line 85: %if "@PYTHON3@" != ""
Line 86: BuildRequires: python3-nose
Line 87: BuildRequires: python3-six


-- 
To view, visit https://gerrit.ovirt.org/52864
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3921cebb7f550f63849f3bc5c80636b6e9495c92
Gerrit-PatchSet: 23
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list